Jeton CSRF sur tous les formulaires POST du portail (#4)

csrf_jeton(), csrf_champ() et csrf_verifier() dans inc/auth.php : un jeton
par session, comparé par hash_equals, réponse 400 s'il manque ou ne
correspond pas. La vérification est appelée en tête de chaque page qui traite
un POST — console d'administration (membres, validation, révocation, groupes,
services) et pages des membres (profil, mot de passe, inscription,
renouvellement d'adhésion) —, et chaque formulaire porte le champ caché.

Ajoute aussi e(), l'échappement de sortie à utiliser dans tout nouveau code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V2csyno8m71DJFKYM1vgzV
This commit is contained in:
Cédrix 2026-10-31 08:50:32 +01:00
parent fc4d010c66
commit 24f3296ec8
No known key found for this signature in database
10 changed files with 62 additions and 0 deletions

View file

@ -6,6 +6,7 @@ require_once __DIR__ . '/../inc/services.php';
session_start_safe(); session_start_safe();
require_admin(); require_admin();
csrf_verifier();
$errors = []; $errors = [];
$success = ''; $success = '';
@ -97,6 +98,7 @@ require __DIR__ . '/../views/layout.php';
<td> <td>
<form method="post" style="display:inline" <form method="post" style="display:inline"
onsubmit="return confirm('Supprimer le groupe « <?= htmlspecialchars(addslashes($g['name'])) ?> » ?')"> onsubmit="return confirm('Supprimer le groupe « <?= htmlspecialchars(addslashes($g['name'])) ?> » ?')">
<?= csrf_champ() ?>
<input type="hidden" name="action" value="delete"> <input type="hidden" name="action" value="delete">
<input type="hidden" name="group_id" value="<?= htmlspecialchars($g['id']) ?>"> <input type="hidden" name="group_id" value="<?= htmlspecialchars($g['id']) ?>">
<button type="submit" class="btn-danger btn-sm">Supprimer</button> <button type="submit" class="btn-danger btn-sm">Supprimer</button>
@ -113,6 +115,7 @@ require __DIR__ . '/../views/layout.php';
<div class="card"> <div class="card">
<h2>Créer un groupe</h2> <h2>Créer un groupe</h2>
<form method="post" style="display:flex; gap:.8rem; align-items:flex-end"> <form method="post" style="display:flex; gap:.8rem; align-items:flex-end">
<?= csrf_champ() ?>
<input type="hidden" name="action" value="create"> <input type="hidden" name="action" value="create">
<div class="form-group" style="margin:0; flex:1"> <div class="form-group" style="margin:0; flex:1">
<label>Nom du groupe</label> <label>Nom du groupe</label>

View file

@ -58,6 +58,7 @@ require __DIR__ . '/../views/layout.php';
<td><?= htmlspecialchars(implode(', ', $u['groupNames']) ?: '—') ?></td> <td><?= htmlspecialchars(implode(', ', $u['groupNames']) ?: '—') ?></td>
<td> <td>
<form method="post" action="/admin/validate.php" style="display:inline"> <form method="post" action="/admin/validate.php" style="display:inline">
<?= csrf_champ() ?>
<input type="hidden" name="user_id" value="<?= htmlspecialchars($u['id']) ?>"> <input type="hidden" name="user_id" value="<?= htmlspecialchars($u['id']) ?>">
<button type="submit" class="btn-primary btn-sm" <button type="submit" class="btn-primary btn-sm"
onclick="return confirm('Valider l\'adhésion de <?= htmlspecialchars(addslashes($u['username'] ?? '')) ?> ?')"> onclick="return confirm('Valider l\'adhésion de <?= htmlspecialchars(addslashes($u['username'] ?? '')) ?> ?')">
@ -93,6 +94,7 @@ require __DIR__ . '/../views/layout.php';
<td><?= htmlspecialchars(implode(', ', $u['groupNames'])) ?></td> <td><?= htmlspecialchars(implode(', ', $u['groupNames'])) ?></td>
<td> <td>
<form method="post" action="/admin/revoke.php" style="display:inline"> <form method="post" action="/admin/revoke.php" style="display:inline">
<?= csrf_champ() ?>
<input type="hidden" name="user_id" value="<?= htmlspecialchars($u['id']) ?>"> <input type="hidden" name="user_id" value="<?= htmlspecialchars($u['id']) ?>">
<button type="submit" class="btn-danger btn-sm" <button type="submit" class="btn-danger btn-sm"
onclick="return confirm('Révoquer l\'adhésion de <?= htmlspecialchars(addslashes($u['username'] ?? '')) ?> ?')"> onclick="return confirm('Révoquer l\'adhésion de <?= htmlspecialchars(addslashes($u['username'] ?? '')) ?> ?')">

View file

@ -5,6 +5,7 @@ require_once __DIR__ . '/../inc/keycloak.php';
session_start_safe(); session_start_safe();
require_admin(); require_admin();
csrf_verifier();
if ($_SERVER['REQUEST_METHOD'] !== 'POST' || empty($_POST['user_id'])) { if ($_SERVER['REQUEST_METHOD'] !== 'POST' || empty($_POST['user_id'])) {
header('Location: /admin/members.php'); header('Location: /admin/members.php');

View file

@ -6,6 +6,7 @@ require_once __DIR__ . '/../inc/keycloak.php';
session_start_safe(); session_start_safe();
require_admin(); require_admin();
csrf_verifier();
$kc_groups = kc_list_groups(); $kc_groups = kc_list_groups();
$group_names = array_column($kc_groups, 'name'); $group_names = array_column($kc_groups, 'name');
@ -56,6 +57,7 @@ require __DIR__ . '/../views/layout.php';
<div class="card"> <div class="card">
<form method="post"> <form method="post">
<?= csrf_champ() ?>
<table class="services-table"> <table class="services-table">
<thead> <thead>
<tr> <tr>

View file

@ -5,6 +5,7 @@ require_once __DIR__ . '/../inc/keycloak.php';
session_start_safe(); session_start_safe();
require_admin(); require_admin();
csrf_verifier();
if ($_SERVER['REQUEST_METHOD'] !== 'POST' || empty($_POST['user_id'])) { if ($_SERVER['REQUEST_METHOD'] !== 'POST' || empty($_POST['user_id'])) {
header('Location: /admin/members.php'); header('Location: /admin/members.php');

View file

@ -6,6 +6,7 @@ require_once __DIR__ . '/../inc/dolibarr.php';
session_start_safe(); session_start_safe();
require_login(); require_login();
csrf_verifier();
$user = current_user(); $user = current_user();
$membership = doli_get_membership($user['email']); $membership = doli_get_membership($user['email']);
@ -67,6 +68,7 @@ require __DIR__ . '/../views/layout.php';
<?php endif; ?> <?php endif; ?>
<form method="post" novalidate> <form method="post" novalidate>
<?= csrf_champ() ?>
<div class="form-group"> <div class="form-group">
<label for="address">Adresse</label> <label for="address">Adresse</label>
<input type="text" id="address" name="address" required <input type="text" id="address" name="address" required

View file

@ -56,3 +56,44 @@ function get_flash(): ?array {
unset($_SESSION['flash']); unset($_SESSION['flash']);
return $flash; return $flash;
} }
// ── Échappement de sortie ─────────────────────────────────────────────
// Tout ce qui part dans une page HTML passe par e() : texte, attribut entre
// guillemets doubles ou simples. Une valeur nulle donne une chaîne vide.
function e(string|int|float|null $valeur): string {
return htmlspecialchars((string)$valeur, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8');
}
// ── Protection CSRF ───────────────────────────────────────────────────
// Un jeton par session, porté par un champ caché dans chaque formulaire POST
// et comparé à temps constant. Il vaut aussi pour un visiteur non connecté
// (inscription) : la session existe dès la première page.
function csrf_jeton(): string {
session_start_safe();
if (empty($_SESSION['csrf_jeton'])) {
$_SESSION['csrf_jeton'] = bin2hex(random_bytes(32));
}
return $_SESSION['csrf_jeton'];
}
function csrf_champ(): string {
return '<input type="hidden" name="csrf_jeton" value="' . e(csrf_jeton()) . '">';
}
// À appeler en tête de chaque traitement POST. Sans effet pour une autre
// méthode ; sinon, jeton absent ou faux : réponse 400 et arrêt.
function csrf_verifier(): void {
if (($_SERVER['REQUEST_METHOD'] ?? 'GET') !== 'POST') return;
session_start_safe();
$attendu = $_SESSION['csrf_jeton'] ?? '';
$recu = $_POST['csrf_jeton'] ?? '';
if (!is_string($recu) || $attendu === '' || !hash_equals($attendu, $recu)) {
http_response_code(400);
header('Content-Type: text/html; charset=UTF-8');
echo '<!DOCTYPE html><html lang="fr"><head><meta charset="UTF-8"><title>Requête refusée</title></head><body>'
. '<h1>Requête refusée</h1>'
. '<p>Le formulaire a expiré ou ne provient pas de ce site (jeton de sécurité absent ou invalide). '
. 'Revenez à la page précédente, rechargez-la, puis recommencez.</p></body></html>';
exit;
}
}

View file

@ -5,6 +5,7 @@ require_once __DIR__ . '/inc/keycloak.php';
session_start_safe(); session_start_safe();
require_login(); require_login();
csrf_verifier();
$user = current_user(); $user = current_user();
$errors = []; $errors = [];
@ -50,6 +51,7 @@ require __DIR__ . '/views/layout.php';
<?php endif; ?> <?php endif; ?>
<form method="post" novalidate> <form method="post" novalidate>
<?= csrf_champ() ?>
<div class="form-group"> <div class="form-group">
<label for="password">Nouveau mot de passe</label> <label for="password">Nouveau mot de passe</label>
<input type="password" id="password" name="password" required minlength="8" autocomplete="new-password"> <input type="password" id="password" name="password" required minlength="8" autocomplete="new-password">

View file

@ -6,6 +6,7 @@ require_once __DIR__ . '/inc/keycloak.php';
session_start_safe(); session_start_safe();
require_login(); require_login();
csrf_verifier();
$user = current_user(); $user = current_user();
$membership = doli_get_membership($user['email']); $membership = doli_get_membership($user['email']);
@ -154,6 +155,7 @@ require __DIR__ . '/views/layout.php';
<?php if ($edit === 'identity'): ?> <?php if ($edit === 'identity'): ?>
<?php if ($errors): ?><div class="alert alert-error"><ul><?php foreach($errors as $e): ?><li><?= htmlspecialchars($e) ?></li><?php endforeach; ?></ul></div><?php endif; ?> <?php if ($errors): ?><div class="alert alert-error"><ul><?php foreach($errors as $e): ?><li><?= htmlspecialchars($e) ?></li><?php endforeach; ?></ul></div><?php endif; ?>
<form method="post" novalidate> <form method="post" novalidate>
<?= csrf_champ() ?>
<input type="hidden" name="section" value="identity"> <input type="hidden" name="section" value="identity">
<div class="form-row"> <div class="form-row">
<div class="form-group"> <div class="form-group">
@ -201,6 +203,7 @@ require __DIR__ . '/views/layout.php';
<?php if ($edit === 'email'): ?> <?php if ($edit === 'email'): ?>
<?php if ($errors): ?><div class="alert alert-error"><ul><?php foreach($errors as $e): ?><li><?= htmlspecialchars($e) ?></li><?php endforeach; ?></ul></div><?php endif; ?> <?php if ($errors): ?><div class="alert alert-error"><ul><?php foreach($errors as $e): ?><li><?= htmlspecialchars($e) ?></li><?php endforeach; ?></ul></div><?php endif; ?>
<form method="post" novalidate> <form method="post" novalidate>
<?= csrf_champ() ?>
<input type="hidden" name="section" value="email"> <input type="hidden" name="section" value="email">
<div class="form-group"> <div class="form-group">
<label>Email actuel</label> <label>Email actuel</label>
@ -275,6 +278,7 @@ require __DIR__ . '/views/layout.php';
<?php if ($edit === 'address' && $membership): ?> <?php if ($edit === 'address' && $membership): ?>
<?php if ($errors): ?><div class="alert alert-error"><ul><?php foreach($errors as $e): ?><li><?= htmlspecialchars($e) ?></li><?php endforeach; ?></ul></div><?php endif; ?> <?php if ($errors): ?><div class="alert alert-error"><ul><?php foreach($errors as $e): ?><li><?= htmlspecialchars($e) ?></li><?php endforeach; ?></ul></div><?php endif; ?>
<form method="post" novalidate> <form method="post" novalidate>
<?= csrf_champ() ?>
<input type="hidden" name="section" value="address"> <input type="hidden" name="section" value="address">
<div class="form-group"> <div class="form-group">
<label>Rue</label> <label>Rue</label>
@ -327,6 +331,7 @@ require __DIR__ . '/views/layout.php';
<div class="tile-body"> <div class="tile-body">
<?php if ($errors): ?><div class="alert alert-error"><ul><?php foreach($errors as $e): ?><li><?= htmlspecialchars($e) ?></li><?php endforeach; ?></ul></div><?php endif; ?> <?php if ($errors): ?><div class="alert alert-error"><ul><?php foreach($errors as $e): ?><li><?= htmlspecialchars($e) ?></li><?php endforeach; ?></ul></div><?php endif; ?>
<form method="post" novalidate> <form method="post" novalidate>
<?= csrf_champ() ?>
<input type="hidden" name="section" value="password"> <input type="hidden" name="section" value="password">
<div class="form-group"> <div class="form-group">
<label>Nouveau mot de passe</label> <label>Nouveau mot de passe</label>
@ -364,6 +369,7 @@ require __DIR__ . '/views/layout.php';
Configurée le <?= date('d/m/Y', (int)($otp['createdDate'] / 1000)) ?> Configurée le <?= date('d/m/Y', (int)($otp['createdDate'] / 1000)) ?>
</p> </p>
<form method="post" onsubmit="return confirm('Supprimer l\'OTP ? Votre compte sera moins sécurisé.')"> <form method="post" onsubmit="return confirm('Supprimer l\'OTP ? Votre compte sera moins sécurisé.')">
<?= csrf_champ() ?>
<input type="hidden" name="section" value="otp_delete"> <input type="hidden" name="section" value="otp_delete">
<input type="hidden" name="credential_id" value="<?= htmlspecialchars($otp['id']) ?>"> <input type="hidden" name="credential_id" value="<?= htmlspecialchars($otp['id']) ?>">
<button type="submit" class="btn-danger btn-sm">Supprimer l'OTP</button> <button type="submit" class="btn-danger btn-sm">Supprimer l'OTP</button>

View file

@ -9,6 +9,7 @@ if (current_user()) {
header('Location: /profile.php'); header('Location: /profile.php');
exit; exit;
} }
csrf_verifier();
$errors = []; $errors = [];
$form = ['email' => '', 'first_name' => '', 'last_name' => '']; $form = ['email' => '', 'first_name' => '', 'last_name' => ''];
@ -65,6 +66,7 @@ require __DIR__ . '/views/layout.php';
<?php endif; ?> <?php endif; ?>
<form method="post" novalidate> <form method="post" novalidate>
<?= csrf_champ() ?>
<div class="form-row"> <div class="form-row">
<div class="form-group"> <div class="form-group">
<label for="first_name">Prénom</label> <label for="first_name">Prénom</label>